Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(metric): optimize calculation of counter rate #342

Conversation

justadogistaken
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@justadogistaken justadogistaken added the workflow/merge-hold merge-hold: code is ready but still has dependency label Nov 3, 2023
@justadogistaken justadogistaken self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 200 lines in your changes are missing coverage. Please review.

Comparison is base (cc764cd) 53.37% compared to head (bc79633) 53.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   53.37%   53.27%   -0.11%     
==========================================
  Files         431      434       +3     
  Lines       47368    47590     +222     
==========================================
+ Hits        25283    25353      +70     
- Misses      19236    19389     +153     
+ Partials     2849     2848       -1     
Flag Coverage Δ
unittest 53.27% <18.36%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/mock/utils.go 100.00% <100.00%> (ø)
...server/agent/metric/malachite/fetcher_calculate.go 67.69% <67.64%> (-6.23%) ⬇️
pkg/metaserver/agent/metric/malachite/fetcher.go 52.56% <0.00%> (-0.54%) ⬇️
pkg/custom-metric/mock/mock_store.go 0.00% <0.00%> (ø)
pkg/custom-metric/mock/mock_collector.go 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justadogistaken justadogistaken added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 6, 2023
@waynepeking348 waynepeking348 merged commit 73207b8 into kubewharf:main Nov 6, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants