Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance(kcmas): lock optimize #343

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Nov 3, 2023

What type of PR is this?

Performance

What this PR does / why we need it:

optimize the lock logic in kcmas store.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Nov 6, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review labels Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1882504) 53.43% compared to head (1bf41eb) 53.51%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   53.43%   53.51%   +0.07%     
==========================================
  Files         434      436       +2     
  Lines       47563    47911     +348     
==========================================
+ Hits        25415    25639     +224     
- Misses      19295    19400     +105     
- Partials     2853     2872      +19     
Flag Coverage Δ
unittest 53.51% <98.22%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/store/local/local_store.go 70.09% <100.00%> (+1.01%) ⬆️
pkg/custom-metric/store/data/cache.go 96.18% <99.07%> (+1.24%) ⬆️
pkg/custom-metric/store/data/internal/internal.go 89.74% <96.29%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb changed the title [WIP]performance(kcmas): lock optimize performance(kcmas): lock optimize Nov 6, 2023
@waynepeking348 waynepeking348 merged commit 5a79950 into kubewharf:main Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants