Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spd support baseline ratio #344

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

spd support baseline ratio

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 3, 2023
@luomingmeng luomingmeng added this to the v0.4 milestone Nov 3, 2023
@luomingmeng luomingmeng self-assigned this Nov 3, 2023
@luomingmeng luomingmeng marked this pull request as ready for review November 3, 2023 13:24
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (1882504) 53.43% compared to head (2a25f94) 53.43%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #344    +/-   ##
========================================
  Coverage   53.43%   53.43%            
========================================
  Files         434      436     +2     
  Lines       47563    47802   +239     
========================================
+ Hits        25415    25544   +129     
- Misses      19295    19380    +85     
- Partials     2853     2878    +25     
Flag Coverage Δ
unittest 53.43% <55.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sadvisor/plugin/qosaware/resource/helper/helper.go 43.24% <54.54%> (-1.21%) ⬇️
pkg/util/spd.go 51.68% <0.00%> (+0.24%) ⬆️
pkg/controller/spd/spd_baseline.go 76.92% <76.92%> (ø)
pkg/metaserver/spd/manager.go 54.87% <13.33%> (-9.31%) ⬇️
pkg/client/control/spd.go 37.03% <34.78%> (-0.47%) ⬇️
pkg/util/spd_baseline.go 68.42% <68.42%> (ø)
pkg/controller/spd/spd.go 55.44% <42.62%> (-1.67%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/spd-support-baseline branch from b9a6afc to 2a25f94 Compare November 3, 2023 14:08
@waynepeking348 waynepeking348 merged commit 0c0b2ed into kubewharf:main Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants