enhancement(sysadvisor): export region reclaimable info as non-reclaim when dedicated_cores can not be co-located with reclaimed_cores

[cheney-lin]

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1882504) 53.43% compared to head (bdd0f20) 53.55%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   53.43%   53.55%   +0.11%     
==========================================
  Files         434      436       +2     
  Lines       47563    47963     +400     
==========================================
+ Hits        25415    25685     +270     
- Misses      19295    19396     +101     
- Partials     2853     2882      +29     

Flag	Coverage Δ
unittest	53.55% <53.84%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...plugin/qosaware/resource/cpu/region/region_base.go	79.17% <100.00%> (+0.24%)	⬆️
...urce/cpu/region/region_dedicated_numa_exclusive.go	75.49% <42.85%> (-8.47%)	⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[waynepeking348]

personally, I would prefer not to define podUID here, since it indicates that only contain one pod can be supported, but the podSet indicates that we should support multiple pods, and it may cause a lot of confusion as the logic goes more and more complex

[waynepeking348]

or we can redefine the high-level design, i.e. "whether it is reasonable to make every region to contain a podSet "

[cheney-lin]

It is necessary to keep the podset because we need to calculate resource usage by it. NewQoSRegionDedicatedNumaExclusive accept containerInfo as one of the parameters indicate that only this region only belong to single Pod.

[waynepeking348]

still confused for keeping both podSet and podUID; besides, NewQoSRegionDedicatedNumaExclusive accept containerInfo as one of the parameters is not a solid reason for keeping podUID or indicating there should be only one pod in this region, since all regions accept containerInfo as one of the parameters (cause we need for its owner pool name) ...

[cheney-lin]

well, I removed podUID of QoSRegionDedicatedNumaExclusive and use getPodUID to get it.