Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(kcmas): object index #349

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Nov 8, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

this PR supports index when query from custom metrics.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Nov 8, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/merge-hold merge-hold: code is ready but still has dependency workflow/need-review review: test succeeded, need to review labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (ad438bc) 53.35% compared to head (121cc5d) 53.54%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   53.35%   53.54%   +0.18%     
==========================================
  Files         436      436              
  Lines       47963    48034      +71     
==========================================
+ Hits        25592    25721     +129     
+ Misses      19490    19429      -61     
- Partials     2881     2884       +3     
Flag Coverage Δ
unittest 53.54% <67.02%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/provider/provider.go 83.40% <ø> (-0.15%) ⬇️
pkg/custom-metric/store/data/cache.go 96.29% <100.00%> (+0.10%) ⬆️
pkg/custom-metric/store/local/local_store.go 66.18% <55.71%> (-3.91%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 8, 2023
@waynepeking348 waynepeking348 merged commit d6330f2 into kubewharf:main Nov 8, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants