Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(kcmas): bucket object store #353

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Nov 9, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

support bucket object store in kcmas

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Nov 9, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 9, 2023
@zzzzhhb zzzzhhb requested review from waynepeking348 and luomingmeng and removed request for waynepeking348 November 9, 2023 07:06
@zzzzhhb zzzzhhb force-pushed the bucket_object_store branch from f2e3e6b to b4a853f Compare November 9, 2023 07:07
@zzzzhhb zzzzhhb force-pushed the bucket_object_store branch from b4a853f to 5e0cbb9 Compare November 9, 2023 07:18
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (d6330f2) 53.46% compared to head (1ce2257) 53.55%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   53.46%   53.55%   +0.09%     
==========================================
  Files         436      437       +1     
  Lines       48034    48135     +101     
==========================================
+ Hits        25679    25778      +99     
+ Misses      19469    19452      -17     
- Partials     2886     2905      +19     
Flag Coverage Δ
unittest 53.55% <72.36%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/store/local/local_store.go 64.28% <50.00%> (-1.91%) ⬇️
pkg/custom-metric/store/data/object_store.go 84.84% <84.84%> (ø)
pkg/custom-metric/store/data/cache.go 83.33% <63.15%> (-12.97%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 9, 2023
@waynepeking348 waynepeking348 merged commit b16f1d0 into kubewharf:main Nov 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants