-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(sysadvisor): update region info atomically #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Nov 13, 2023
cheney-lin
force-pushed
the
dev/logs
branch
3 times, most recently
from
November 13, 2023 06:45
2e66bc7
to
44e2e07
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 53.59% 53.28% -0.31%
==========================================
Files 437 437
Lines 48147 48149 +2
==========================================
- Hits 25803 25655 -148
- Misses 19442 19597 +155
+ Partials 2902 2897 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waynepeking348
previously approved these changes
Nov 13, 2023
cheney-lin
changed the title
enhancement(sysadvisor): add logs
enhancement(sysadvisor): update region info atomically
Nov 13, 2023
sun-yuliang
reviewed
Nov 13, 2023
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/advisor_helper.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/advisor_helper.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/advisor_helper.go
Outdated
Show resolved
Hide resolved
cheney-lin
force-pushed
the
dev/logs
branch
2 times, most recently
from
November 13, 2023 09:18
e7e1e90
to
d94e9b7
Compare
sun-yuliang
previously approved these changes
Nov 13, 2023
cheney-lin
added
workflow/merge-ready
merge-ready: code is ready and can be merged
and removed
workflow/need-review
review: test succeeded, need to review
labels
Nov 13, 2023
waynepeking348
previously approved these changes
Nov 13, 2023
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
dismissed stale reviews from waynepeking348 and sun-yuliang
via
November 14, 2023 07:41
5159d38
sun-yuliang
approved these changes
Nov 14, 2023
waynepeking348
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: