Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(sysadvisor): update region info atomically #358

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin self-assigned this Nov 13, 2023
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Nov 13, 2023
@cheney-lin cheney-lin force-pushed the dev/logs branch 3 times, most recently from 2e66bc7 to 44e2e07 Compare November 13, 2023 06:45
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (11942ce) 53.59% compared to head (5159d38) 53.28%.
Report is 4 commits behind head on main.

Files Patch % Lines
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 68.42% 4 Missing and 2 partials ⚠️
...assembler/headroomassembler/assembler_dedicated.go 50.00% 1 Missing and 1 partial ⚠️
...sadvisor/plugin/qosaware/resource/helper/helper.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   53.59%   53.28%   -0.31%     
==========================================
  Files         437      437              
  Lines       48147    48149       +2     
==========================================
- Hits        25803    25655     -148     
- Misses      19442    19597     +155     
+ Partials     2902     2897       -5     
Flag Coverage Δ
unittest 53.28% <67.85%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Nov 13, 2023
@cheney-lin cheney-lin changed the title enhancement(sysadvisor): add logs enhancement(sysadvisor): update region info atomically Nov 13, 2023
@cheney-lin cheney-lin force-pushed the dev/logs branch 2 times, most recently from e7e1e90 to d94e9b7 Compare November 13, 2023 09:18
sun-yuliang
sun-yuliang previously approved these changes Nov 13, 2023
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Nov 13, 2023
waynepeking348
waynepeking348 previously approved these changes Nov 13, 2023
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@waynepeking348 waynepeking348 merged commit a7052c7 into kubewharf:main Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants