Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine numa-aware memory headroom policy #359

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

LuyaoZhong
Copy link
Contributor

calculate memory headroom by system free, reclaimed-core container request and system watermark.

calculate memory headroom by system free, reclaimed-core container request
and system watermark.
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf2d03c) 53.26% compared to head (f74d160) 53.22%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   53.26%   53.22%   -0.04%     
==========================================
  Files         431      437       +6     
  Lines       47320    48157     +837     
==========================================
+ Hits        25204    25631     +427     
- Misses      19261    19623     +362     
- Partials     2855     2903      +48     
Flag Coverage Δ
unittest 53.22% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...esource/memory/headroompolicy/policy_numa_aware.go 81.81% <100.00%> (-0.38%) ⬇️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Nov 13, 2023
@waynepeking348 waynepeking348 added enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 13, 2023
@cheney-lin cheney-lin added workflow/merge-hold merge-hold: code is ready but still has dependency and removed workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 13, 2023
@waynepeking348 waynepeking348 added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 14, 2023
@waynepeking348 waynepeking348 merged commit 8d61a49 into kubewharf:main Nov 14, 2023
10 of 11 checks passed
@LuyaoZhong LuyaoZhong deleted the mem_headroom branch November 29, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants