Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs for creating isolation region multiple times #363

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

bug fixes

What this PR does / why we need it:

fix bugs for isolation region be created multiple times

@waynepeking348 waynepeking348 added bug Something isn't working workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 14, 2023
@waynepeking348 waynepeking348 self-assigned this Nov 14, 2023
@waynepeking348 waynepeking348 force-pushed the fix-bugs-for-always-creating-isolation-regions branch from 60a70e4 to 0e0e9df Compare November 14, 2023 13:55
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8d61a49) 53.43% compared to head (0e0e9df) 53.41%.
Report is 1 commits behind head on main.

Files Patch % Lines
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 67.85% 6 Missing and 3 partials ⚠️
...assembler/headroomassembler/assembler_dedicated.go 50.00% 1 Missing and 1 partial ⚠️
...sadvisor/plugin/qosaware/resource/helper/helper.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   53.43%   53.41%   -0.03%     
==========================================
  Files         437      437              
  Lines       48155    48150       -5     
==========================================
- Hits        25732    25717      -15     
- Misses      19505    19527      +22     
+ Partials     2918     2906      -12     
Flag Coverage Δ
unittest 53.41% <70.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit d28330e into kubewharf:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants