unified solution for TCP memory limitation #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_sockmem
branch
from
54c1653 to
5943b21
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 53.35% 53.43% +0.07%
==========================================
Files 436 438 +2
Lines 47963 48310 +347
==========================================
+ Hits 25592 25813 +221
- Misses 19490 19579 +89
- Partials 2881 2918 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lubinszARM
force-pushed
the
pr_sockmem
branch
2 times, most recently
from
8e89c3f to
cad3cb5
Compare
| @@ -245,6 +252,11 @@ func (p *DynamicPolicy) Start() (err error) { | |||
| go wait.Until(p.setMemoryMigrate, setMemoryMigratePeriod, p.stopCh) | |||
| } | |||
|
|
|||
| if p.enableSettingSockMem { | |||
There was a problem hiding this comment.
register as RegisterPeriodicalHandler will be better
| * 2, do nothing for cgroupv2. | ||
| * 3, set pod tcp_mem accounting for cgroupv1. | ||
| */ | ||
| func (p *DynamicPolicy) setSockMemLimit() { |
There was a problem hiding this comment.
will it be better if we add a new dir handlers for RegisterPeriodicalHandler ? @csfldf
lubinszARM
force-pushed
the
pr_sockmem
branch
from
cad3cb5 to
503d2a7
Compare
waynepeking348
added
enhancement
lubinszARM
force-pushed
the
pr_sockmem
branch
3 times, most recently
from
2d539c5 to
7da0e19
Compare
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_sockmem
branch
from
7da0e19 to
a20579b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
The feature provides the unified solution for TCP memory limitation in cgroup and host level.
Which issue(s) this PR fixes:
Special notes for your reviewer:
The feature includes 3 parts:
1, Set the limit value for host net.ipv4.tcp_mem.
The default value is 20% of host toal memory.
2, Do nothing for cgroupv2.
3, Set pod tcp_mem accounting for cgroupv1.
The default value is same with memory.limit_in_bytes.