Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(spd): get spd by workload's name #369

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin changed the title Dev/spd refine enhancement(spd): get spd by workload's name Nov 20, 2023
@cheney-lin cheney-lin self-assigned this Nov 20, 2023
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Nov 20, 2023
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b30e850) 53.38% compared to head (cbd3bf0) 53.49%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/util/spd.go 60.00% 1 Missing and 1 partial ⚠️
pkg/controller/spd/spd.go 95.23% 0 Missing and 1 partial ⚠️
pkg/webhook/mutating/pod/spd_ref_mutator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   53.38%   53.49%   +0.10%     
==========================================
  Files         437      437              
  Lines       48140    48155      +15     
==========================================
+ Hits        25699    25759      +60     
+ Misses      19535    19485      -50     
- Partials     2906     2911       +5     
Flag Coverage Δ
unittest 53.49% <86.20%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 8fe8ab3 into kubewharf:main Nov 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants