fix(sysadvisor): fix create duplicated regions for distinct container… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 50.99% 50.93% -0.07%
==========================================
Files 311 311
Lines 31796 31822 +26
==========================================
- Hits 16215 16209 -6
- Misses 13666 13694 +28
- Partials 1915 1919 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
fix/duplicate_regions
branch
3 times, most recently
from
b6fce35 to
0c5c04e
Compare
waynepeking348
previously approved these changes
Apr 23, 2023
|
why don't we just store container -> region info in metacache's container-info? for instance, other metrics pipeline will also need to get this mapping relationships too cc @sun-yuliang |
cheney-lin
force-pushed
the
fix/duplicate_regions
branch
2 times, most recently
from
6e2242e to
e9d0d71
Compare
waynepeking348
previously approved these changes
Apr 24, 2023
cheney-lin
added
workflow/merge-ready
sun-yuliang
reviewed
Apr 24, 2023
| } | ||
| return nil, false | ||
| return regions, nil | ||
| } | ||
|
|
||
| func (cra *cpuResourceAdvisor) setContainerRegions(ci *types.ContainerInfo, regions []region.QoSRegion) { |
There was a problem hiding this comment.
setContainerRegions will not change container info in metacache because it is called by metacache.RangeContainer, which is a reader function. Use RangeAndUpdateContainer instead.
| containerRegionMap map[string]map[string][]region.QoSRegion // map[podUID][containerName]regions | ||
| poolRegionMap map[string][]region.QoSRegion // map[poolName]regions | ||
| regionMap map[string]region.QoSRegion // map[regionName]region | ||
| poolRegionMap map[string][]region.QoSRegion // map[poolName]regions |
There was a problem hiding this comment.
Move pool region names to pool info in metacache as region names in container info.
cheney-lin
force-pushed
the
fix/duplicate_regions
branch
4 times, most recently
from
1e2db42 to
dc0a0a2
Compare
sun-yuliang
previously approved these changes
Apr 24, 2023
cheney-lin
force-pushed
the
fix/duplicate_regions
branch
from
dc0a0a2 to
bfdc398
Compare
…ers owned to identical pod Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
fix/duplicate_regions
branch
from
bfdc398 to
ea621e6
Compare
waynepeking348
approved these changes
Apr 25, 2023
sun-yuliang
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s owned to identical pod
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: