Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to the latest version of katalyst api #373

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

docs

What this PR does / why we need it:

add detailed comments for katalyst enhancements and other consts

@waynepeking348 waynepeking348 self-assigned this Nov 21, 2023
@waynepeking348 waynepeking348 added documentation Improvements or additions to documentation workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 21, 2023
@waynepeking348 waynepeking348 force-pushed the ref-to-latest-api-version branch from 689de5f to fe0ed53 Compare November 21, 2023 13:03
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fe8ab3) 53.46% compared to head (fe0ed53) 53.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   53.46%   53.19%   -0.27%     
==========================================
  Files         437      437              
  Lines       48155    48155              
==========================================
- Hits        25744    25618     -126     
- Misses      19492    19629     +137     
+ Partials     2919     2908      -11     
Flag Coverage Δ
unittest 53.19% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit e333907 into kubewharf:main Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants