Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node updater support patch node status #379

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review November 27, 2023 13:37
@luomingmeng luomingmeng self-assigned this Nov 27, 2023
@luomingmeng luomingmeng added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (a310c49) 53.42% compared to head (1ff1f76) 53.41%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/client/control/node.go 26.08% 12 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   53.42%   53.41%   -0.02%     
==========================================
  Files         439      439              
  Lines       48373    48366       -7     
==========================================
- Hits        25844    25833      -11     
+ Misses      19598    19593       -5     
- Partials     2931     2940       +9     
Flag Coverage Δ
unittest 53.41% <26.08%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/node_updater_support_patch_node_status branch from 9d62d21 to 1809574 Compare November 27, 2023 14:07
waynepeking348
waynepeking348 previously approved these changes Nov 27, 2023
@luomingmeng luomingmeng requested a review from csfldf November 27, 2023 14:11
@waynepeking348 waynepeking348 merged commit 01c79af into kubewharf:main Nov 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants