Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sysadvisor): emit metrics even when reclaim disabled #38

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review chore and removed bug Something isn't working labels Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.01 ⚠️

Comparison is base (f3ce63d) 50.92% compared to head (a5e77fc) 50.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   50.92%   50.91%   -0.01%     
==========================================
  Files         311      311              
  Lines       31785    31790       +5     
==========================================
+ Hits        16185    16187       +2     
- Misses      13682    13684       +2     
- Partials     1918     1919       +1     
Flag Coverage Δ
unittest 50.91% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/plugin/qosaware/reporter/manager/resource/cpu.go 100.00% <ø> (ø)
...lugin/qosaware/reporter/manager/resource/memory.go 100.00% <ø> (ø)
.../sysadvisor/qosaware/reporter/headroom_reporter.go 100.00% <ø> (ø)
.../sysadvisor/qosaware/reporter/headroom_reporter.go 70.83% <66.66%> (ø)
...ugin/qosaware/reporter/manager/resource/generic.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@waynepeking348
Copy link
Collaborator

why we still need to emit reclaimed resources when reclaim is disabled?

@cheney-lin
Copy link
Member Author

Make the metrics continuous. Image that if the metrics between time1 to time2 is missed, the front-end grafana will connect the two point directly, giving the impression that the headrooms in this time span is non-zero.

@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Apr 25, 2023
@waynepeking348 waynepeking348 merged commit 3380873 into kubewharf:main Apr 25, 2023
@cheney-lin cheney-lin deleted the dev/emit_metrics branch September 13, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants