feat(sysadvisor): Refined NUMA-granularity Memory Management and Control Framework #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
2 times, most recently
from
d9428e0 to
a1b22af
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 53.41% 53.61% +0.20%
==========================================
Files 448 454 +6
Lines 50138 50370 +232
==========================================
+ Hits 26782 27007 +225
- Misses 20298 20300 +2
- Partials 3058 3063 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
a1b22af to
87504f6
Compare
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
87504f6 to
b3f0730
Compare
luomingmeng
reviewed
Nov 29, 2023
pkg/agent/qrm-plugins/memory/dynamicpolicy/memoryadvisor/policy_control_knob_handlers.go
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/headroompolicy/policy_numa_aware.go
Outdated
Show resolved
Hide resolved
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
3 times, most recently
from
a346fad to
e8d7f3c
Compare
luomingmeng
reviewed
Nov 30, 2023
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/provisioner/policy_canonical.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_provisioner.go
Outdated
Show resolved
Hide resolved
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
e8d7f3c to
399d505
Compare
Lan-ce-lot
changed the title
luomingmeng
previously approved these changes
Dec 15, 2023
cmd/katalyst-agent/app/options/sysadvisor/qosaware/resource/memory/memory_advisor.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/advisor.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_provisioner.go
Outdated
Show resolved
Hide resolved
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
8b56749 to
399d505
Compare
waynepeking348
added
the
workflow/merge-ready
luomingmeng
previously approved these changes
Dec 21, 2023
waynepeking348
previously approved these changes
Dec 21, 2023
csfldf
reviewed
Dec 25, 2023
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_advisor_handler.go
Outdated
Show resolved
Hide resolved
csfldf
previously approved these changes
Dec 25, 2023
Lan-ce-lot
dismissed stale reviews from csfldf and waynepeking348
via
6c7b4ad
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
d1f35e6 to
6c7b4ad
Compare
Lan-ce-lot
force-pushed
the
feat/mem-provision
branch
from
6c7b4ad to
fb7902a
Compare
luomingmeng
approved these changes
Dec 25, 2023
sun-yuliang
approved these changes
Dec 27, 2023
csfldf
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#217
Special notes for your reviewer:
@luomingmeng