Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for eviction and handlers #382

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

add more metrics and tags for eviction and qrm logic

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 28, 2023
@waynepeking348 waynepeking348 self-assigned this Nov 28, 2023
@waynepeking348 waynepeking348 force-pushed the add-metrics-for-control-knobs branch from e2afc87 to add7a97 Compare November 28, 2023 11:41
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (01c79af) 53.40% compared to head (b137e6c) 53.36%.
Report is 1 commits behind head on main.

❗ Current head b137e6c differs from pull request most recent head 4a4d57d. Consider uploading reports for the commit 4a4d57d to get more accurate results

Files Patch % Lines
pkg/util/asyncworker/helpers.go 46.66% 12 Missing and 4 partials ⚠️
...m-plugins/memory/handlers/sockmem/sockmem_linux.go 23.07% 10 Missing ⚠️
...m-plugins/memory/dynamicpolicy/util_linux_amd64.go 0.00% 8 Missing ⚠️
pkg/util/cgroup/manager/cgroup.go 0.00% 8 Missing ⚠️
pkg/agent/evictionmanager/podkiller/podkiller.go 0.00% 5 Missing ⚠️
pkg/agent/evictionmanager/podkiller/killer.go 75.00% 4 Missing ⚠️
...plugin/qosaware/resource/cpu/region/region_base.go 0.00% 3 Missing and 1 partial ⚠️
pkg/util/asyncworker/async_workers.go 81.81% 2 Missing ⚠️
pkg/agent/qrm-plugins/util/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   53.40%   53.36%   -0.05%     
==========================================
  Files         439      439              
  Lines       48366    48423      +57     
==========================================
+ Hits        25830    25839       +9     
- Misses      19606    19653      +47     
- Partials     2930     2931       +1     
Flag Coverage Δ
unittest 53.36% <41.41%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 force-pushed the add-metrics-for-control-knobs branch from add7a97 to 219a02c Compare November 28, 2023 16:04
@waynepeking348 waynepeking348 added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 28, 2023
@waynepeking348 waynepeking348 force-pushed the add-metrics-for-control-knobs branch 3 times, most recently from f48c34c to b137e6c Compare November 29, 2023 06:02
zzzzhhb
zzzzhhb previously approved these changes Nov 29, 2023
csfldf
csfldf previously approved these changes Nov 29, 2023
@waynepeking348 waynepeking348 dismissed stale reviews from csfldf and zzzzhhb via 4a4d57d November 29, 2023 09:34
@waynepeking348 waynepeking348 force-pushed the add-metrics-for-control-knobs branch from b137e6c to 4a4d57d Compare November 29, 2023 09:34
@waynepeking348 waynepeking348 merged commit 8d1f2a2 into kubewharf:main Nov 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants