modify numa-aware memory headroom policy to consider about inactive pages #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuyaoZhong
force-pushed
the
mem_headroom
branch
from
d9ae790 to
3a6c85b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 53.78% 53.57% -0.22%
==========================================
Files 446 446
Lines 49411 49422 +11
==========================================
- Hits 26578 26478 -100
- Misses 19830 19943 +113
+ Partials 3003 3001 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
pls make the commit message more meaningful to let others know exactly what you wan to modify |
LuyaoZhong
force-pushed
the
mem_headroom
branch
from
3a6c85b to
bed462b
Compare
cheney-lin
reviewed
Nov 29, 2023
| @@ -121,6 +122,14 @@ func (p *PolicyNUMAAware) Update() (err error) { | |||
| reclaimableMemory += data.Value | |||
| general.InfoS("reclaimable numa memory free", "numaID", numaID, "numaFree", general.FormatMemoryQuantity(data.Value)) | |||
|
|
|||
| data, err = p.metaServer.GetNumaMetric(numaID, consts.MetricMemInactiveFileNuma) | |||
| if err != nil { | |||
| general.InfoS("failed to get numa inactive file", "numaID", numaID) | |||
There was a problem hiding this comment.
inactive file is kind of buffer, we can return headroom without buffer, return error seems a overkill here.
There was a problem hiding this comment.
If the loss of this metric is accidental，headroom may change abruptly.
There was a problem hiding this comment.
OK, it makes sense.
| @@ -22,6 +22,8 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/kubewharf/katalyst-core/pkg/config/agent/dynamic/adminqos/reclaimedresource/memoryheadroom" | |||
There was a problem hiding this comment.
code style: sort goimports by 3 groups: std, general, project dependencies.
LuyaoZhong
force-pushed
the
mem_headroom
branch
from
33d2600 to
91b6bc8
Compare
cheney-lin
previously approved these changes
Nov 30, 2023
cheney-lin
added
enhancement
waynepeking348
changed the title
waynepeking348
previously approved these changes
Nov 30, 2023
Numa-aware memory headroom was calculated by
reclaimable numa free - 2 * watermark_reserved - config_reserved + reclaimed-core requests
Double watermark reservation reserved the memory too much. Besides, portion of inactive file should be
considered as cold pages on the system, which could be charged to memory headroom since it's easy to
be reclaimed by kernel reclaim mechanism.
Therefore, numa-ware memory headroom will be calculated by
reclaimable numa free - watermark_reserved - config_reserved + cacheBasedRatio * numaInactiveFile + reclaimed-core requests
LuyaoZhong
force-pushed
the
mem_headroom
branch
from
91b6bc8 to
9439d07
Compare
LuyaoZhong
dismissed stale reviews from cheney-lin and waynepeking348
via
130a9cc
waynepeking348
approved these changes
Dec 5, 2023
cheney-lin
approved these changes
Dec 11, 2023
cheney-lin
added
workflow/merge-ready
waynepeking348
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numa-aware memory headroom was calculated by
Double watermark reservation reserved the memory too much. Besides, portion of inactive file should be
considered as cold pages on the system, which could be charged to memory headroom since it's easy to
be reclaimed by kernel reclaim mechanism.
Therefore, numa-ware memory headroom will be calculated by