-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tide): support tide nodepool #387
Conversation
00a0bf0
to
3f4ec51
Compare
you should add enough ut logic for this pr @xjh1996 |
92eadaa
to
6afd1db
Compare
k8s.io/client-go v0.24.6 | ||
k8s.io/component-base v0.24.6 | ||
k8s.io/component-helpers v0.24.6 | ||
k8s.io/api v0.24.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it inevitable to upgrade go mod dependency for k8s-related repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly considered for stability, prefer not to do it if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggered by the necessary dependency cluster-autoscaler. At the bottom of the go mod, there is a replace directive. Theoretically, the version used is still v0.24.6.
lgtm @caohe pls have a look for this pr |
pkg/controller/tide/tide.go
Outdated
return nodeUsageList, nil | ||
} | ||
|
||
// clearUnexpectedCNR is used to clear unexpected cnr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this comment may be not relevant to this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Could you add more information to the description part? |
|
What type of PR is this?
#213
What this PR does / why we need it:
Support tide node pool in katalyst. When a workload is scaled down, the vacant nodes will be identified and assigned to another workload that is experiencing higher demand. This will facilitate the efficient utilization of nodes and prevent resource wastage.
Which issue(s) this PR fixes:
Special notes for your reviewer: