fix(spd): parseBaselineCoefficient returns error if BaselineCoefficient is empty #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
force-pushed
the
fix/spd
branch
6 times, most recently
from
30c3311 to
69474ad
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 53.30% 53.26% -0.04%
==========================================
Files 439 439
Lines 48429 48408 -21
==========================================
- Hits 25816 25786 -30
- Misses 19685 19693 +8
- Partials 2928 2929 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
fix/spd
branch
4 times, most recently
from
5954974 to
efb49ea
Compare
cheney-lin
changed the title
cheney-lin
added
bug
cheney-lin
force-pushed
the
fix/spd
branch
3 times, most recently
from
7ffd5eb to
2033307
Compare
waynepeking348
previously approved these changes
Dec 1, 2023
luomingmeng
reviewed
Dec 1, 2023
pkg/util/spd_baseline.go
Outdated
| ) | ||
|
|
||
| type BaselineCoefficient []int64 | ||
| type PodMeta struct { |
There was a problem hiding this comment.
To avoid conflict with other definitions, consider adding a prefix of spd baseline
…nt is empty If baselinePercent is set as 100%, annotation.SPDAnnotationBaselinePercentileKey will be updated as empty, error occurs when parseBaselineCoefficient, which prints as followed: "[update] [qosaware-memory] update headroom policy failed" err="index 0 cannot parse: strconv.Atoi: parsing \"\": invalid syntax" headroomPolicy=numa-aware By the way, I refined relative logic, removing confuesd BaselinePercentile value and replace by human readable sentinel pod. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
luomingmeng
approved these changes
Dec 1, 2023
cheney-lin
added
workflow/merge-ready
waynepeking348
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: