feat(metaserver): support get pod by uid #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
enhancement
cheney-lin
force-pushed
the
dev/get_pod_by_uid
branch
from
805c618 to
cb98978
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 50.99% 50.88% -0.11%
==========================================
Files 311 315 +4
Lines 31796 32126 +330
==========================================
+ Hits 16215 16348 +133
- Misses 13666 13844 +178
- Partials 1915 1934 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
dev/get_pod_by_uid
branch
2 times, most recently
from
517b930 to
546a5f8
Compare
luomingmeng
previously approved these changes
Apr 25, 2023
|
pod-fetcher interface is kind of mess and should be refined before it can be approved cc @luomingmeng |
luomingmeng
reviewed
Apr 25, 2023
cheney-lin
force-pushed
the
dev/get_pod_by_uid
branch
from
546a5f8 to
c4478b9
Compare
luomingmeng
reviewed
Apr 25, 2023
cheney-lin
force-pushed
the
dev/get_pod_by_uid
branch
from
c4478b9 to
b30df61
Compare
luomingmeng
previously approved these changes
Apr 25, 2023
pkg/metaserver/agent/pod/kubelet.go
Outdated
| // GetPodList get pods from kubelet 10255/pods api, and the returned slice does not | ||
| // contain pods that don't pass `podFilter` | ||
| func (k *kubeletPodFetcherImpl) GetPodList(_ context.Context, podFilter func(*v1.Pod) bool) ([]*v1.Pod, error) { | ||
| func getPodsByKubeletAPI() (v1.PodList, error) { |
There was a problem hiding this comment.
why we need to extract this function out? @cheney-lin
There was a problem hiding this comment.
No need any more, removed already.
cheney-lin
added
workflow/merge-ready
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/get_pod_by_uid
branch
from
b30df61 to
6113f3d
Compare
waynepeking348
approved these changes
Apr 27, 2023
luomingmeng
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: