Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kcmas): multiple metric labels #390

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Dec 1, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

support multiple combinations of metric labels.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-hold merge-hold: code is ready but still has dependency labels Dec 1, 2023
@zzzzhhb zzzzhhb self-assigned this Dec 1, 2023
@zzzzhhb zzzzhhb force-pushed the multi_metric_labels branch from 3ebd08a to c47decf Compare December 1, 2023 08:17
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (1d2526f) 53.43% compared to head (5a1c77a) 53.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/custom-metric/store/data/internal/internal.go 75.42% 40 Missing and 18 partials ⚠️
...visor/plugin/metric-emitter/syncer/node/advisor.go 0.00% 11 Missing ⚠️
...g/util/service-discovery/service_single_port_sd.go 60.00% 1 Missing and 3 partials ⚠️
pkg/custom-metric/store/data/types/metric.go 83.33% 2 Missing and 1 partial ⚠️
pkg/util/general/common.go 50.00% 2 Missing and 1 partial ⚠️
pkg/custom-metric/provider/provider.go 66.66% 1 Missing ⚠️
pkg/custom-metric/store/local/local_store.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   53.43%   53.47%   +0.03%     
==========================================
  Files         439      439              
  Lines       48419    48638     +219     
==========================================
+ Hits        25874    26007     +133     
- Misses      19608    19687      +79     
- Partials     2937     2944       +7     
Flag Coverage Δ
unittest 53.47% <75.96%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb force-pushed the multi_metric_labels branch from f9d841b to 3c8ef33 Compare December 4, 2023 03:15
@zzzzhhb zzzzhhb force-pushed the multi_metric_labels branch from 6856fa8 to 4833878 Compare December 4, 2023 03:57
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Dec 4, 2023
@waynepeking348 waynepeking348 merged commit e8c5fa6 into kubewharf:main Dec 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants