Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysadvisor): emit bound type code for knob status #391

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Dec 1, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

emit bound type code for knob status

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Dec 1, 2023
@zzzzhhb zzzzhhb added workflow/need-review review: test succeeded, need to review enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1d2526f) 53.43% compared to head (70be0d5) 53.35%.

Files Patch % Lines
...visor/plugin/metric-emitter/syncer/node/advisor.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   53.43%   53.35%   -0.09%     
==========================================
  Files         439      439              
  Lines       48419    48419              
==========================================
- Hits        25874    25835      -39     
- Misses      19608    19659      +51     
+ Partials     2937     2925      -12     
Flag Coverage Δ
unittest 53.35% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit c20f950 into kubewharf:main Dec 1, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants