Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kcmas): missing store instance in same node #392

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Dec 1, 2023

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

When more than one store instances are scheduled on same node, only one instance can be used.

Special notes for your reviewer:

@zzzzhhb zzzzhhb added bug Something isn't working workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Dec 1, 2023
@zzzzhhb zzzzhhb self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1d2526f) 53.43% compared to head (e8ac22c) 53.24%.

Files Patch % Lines
...g/util/service-discovery/service_single_port_sd.go 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   53.43%   53.24%   -0.19%     
==========================================
  Files         439      439              
  Lines       48419    48424       +5     
==========================================
- Hits        25874    25785      -89     
- Misses      19608    19706      +98     
+ Partials     2937     2933       -4     
Flag Coverage Δ
unittest 53.24% <60.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 7f0b20b into kubewharf:main Dec 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants