Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spd): baseline checking #393

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Dec 4, 2023
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1d2526f) 53.43% compared to head (9465d3d) 53.46%.
Report is 3 commits behind head on main.

Files Patch % Lines
...visor/plugin/metric-emitter/syncer/node/advisor.go 0.00% 5 Missing ⚠️
...g/util/service-discovery/service_single_port_sd.go 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   53.43%   53.46%   +0.03%     
==========================================
  Files         439      444       +5     
  Lines       48419    48807     +388     
==========================================
+ Hits        25874    26096     +222     
- Misses      19608    19767     +159     
- Partials     2937     2944       +7     
Flag Coverage Δ
unittest 53.46% <47.05%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Dec 4, 2023
@waynepeking348 waynepeking348 merged commit 08fdafe into kubewharf:main Dec 4, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants