Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): adapt drop cache operation with cgv2 #394

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Dec 4, 2023

feat(qrm): adapt drop cache operation with cgv2

@csfldf csfldf self-assigned this Dec 4, 2023
@csfldf csfldf force-pushed the dev/cgv2_drop_cache branch from fd787d1 to 1a112b5 Compare December 4, 2023 12:32
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (e8c5fa6) 53.59% compared to head (abc6f8a) 53.46%.

Files Patch % Lines
pkg/util/cgroup/manager/cgroup.go 53.33% 6 Missing and 1 partial ⚠️
...memory/dynamicpolicy/policy_allocation_handlers.go 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   53.59%   53.46%   -0.14%     
==========================================
  Files         444      444              
  Lines       49021    49043      +22     
==========================================
- Hits        26273    26219      -54     
- Misses      19791    19859      +68     
- Partials     2957     2965       +8     
Flag Coverage Δ
unittest 53.46% <53.57%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/cgv2_drop_cache branch from 1a112b5 to abc6f8a Compare December 5, 2023 06:46
@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Dec 5, 2023
@waynepeking348 waynepeking348 merged commit bd446c3 into kubewharf:main Dec 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants