Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor cpu pressure eviction framework #395

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

refactor cpu pressure eviction framework to make the eviction strategy be an independent eviction plugin, which is more friendly to metrics observation

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review December 5, 2023 15:45
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (e8c5fa6) 53.59% compared to head (cc37e3a) 53.63%.

Files Patch % Lines
...cpu/dynamicpolicy/cpueviction/strategy/pressure.go 51.06% 21 Missing and 2 partials ⚠️
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 71.42% 9 Missing and 3 partials ⚠️
...olicy/cpueviction/strategy/pressure_suppression.go 45.45% 6 Missing ⚠️
...ynamicpolicy/cpueviction/strategy/pressure_load.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   53.59%   53.63%   +0.03%     
==========================================
  Files         444      445       +1     
  Lines       49021    48998      -23     
==========================================
+ Hits        26273    26278       +5     
+ Misses      19791    19762      -29     
- Partials     2957     2958       +1     
Flag Coverage Δ
unittest 53.63% <58.65%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/fix_cpu_pressure_suppression_eviction branch 2 times, most recently from 09190e4 to 309cd8c Compare December 5, 2023 16:07
@luomingmeng luomingmeng force-pushed the dev/fix_cpu_pressure_suppression_eviction branch from 309cd8c to cd61016 Compare December 6, 2023 02:23
waynepeking348
waynepeking348 previously approved these changes Dec 6, 2023
@luomingmeng luomingmeng force-pushed the dev/fix_cpu_pressure_suppression_eviction branch from b025108 to cc37e3a Compare December 6, 2023 02:50
@waynepeking348 waynepeking348 merged commit ff9c467 into kubewharf:main Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants