Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppression eviction add PodUniqKeyCmpFunc to make sure the sort result is stable #397

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

suppression eviction add PodUniqKeyCmpFunc to make sure the sort result is stable

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/suppression_make_sure_sort_result_stable branch from 32d42a0 to 6ad53f1 Compare December 6, 2023 07:35
@luomingmeng luomingmeng marked this pull request as ready for review December 6, 2023 07:36
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (af858f2) 53.88% compared to head (76de41f) 53.60%.

Files Patch % Lines
...olicy/cpueviction/strategy/pressure_suppression.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   53.88%   53.60%   -0.28%     
==========================================
  Files         445      445              
  Lines       49040    49054      +14     
==========================================
- Hits        26423    26296     -127     
- Misses      19651    19800     +149     
+ Partials     2966     2958       -8     
Flag Coverage Δ
unittest 53.60% <88.23%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/suppression_make_sure_sort_result_stable branch 3 times, most recently from 89cc8ae to 2812ecc Compare December 6, 2023 08:43
@luomingmeng luomingmeng force-pushed the dev/suppression_make_sure_sort_result_stable branch from 2812ecc to 76de41f Compare December 6, 2023 08:57
@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Dec 6, 2023
@waynepeking348 waynepeking348 merged commit 871cdd7 into kubewharf:main Dec 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants