Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): add interface Empty() to determine whether samples should… #398

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

cheney-lin
Copy link
Member

… be reclaimed

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@waynepeking348 waynepeking348 added the bug Something isn't working label Dec 11, 2023
@cheney-lin cheney-lin added enhancement New feature or request and removed bug Something isn't working labels Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871cdd7) 53.88% compared to head (318aa36) 53.77%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   53.88%   53.77%   -0.11%     
==========================================
  Files         445      445              
  Lines       49054    49065      +11     
==========================================
- Hits        26432    26385      -47     
- Misses      19656    19712      +56     
- Partials     2966     2968       +2     
Flag Coverage Δ
unittest 53.77% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… be reclaimed

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin added the workflow/need-review review: test succeeded, need to review label Dec 11, 2023
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Dec 13, 2023
@waynepeking348 waynepeking348 merged commit c04d422 into kubewharf:main Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants