feat(qrm): support getting specified pool name in QoS conf #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 53.68% 53.53% -0.16%
==========================================
Files 446 446
Lines 49384 49385 +1
==========================================
- Hits 26514 26437 -77
- Misses 19860 19946 +86
+ Partials 3010 3002 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
csfldf
force-pushed
the
dev/qos_get_pool_name
branch
from
0aebc70 to
bff65a5
Compare
luomingmeng
approved these changes
Dec 12, 2023
csfldf
added
the
workflow/merge-ready
waynepeking348
approved these changes
Dec 12, 2023
| @@ -509,3 +509,52 @@ func TestGenerateCPUMachineStateByPodEntries(t *testing.T) { | |||
| os.RemoveAll(tmpDir) | |||
| } | |||
| } | |||
|
|
|||
| func TestGetSpecifiedPoolName(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(qrm): support getting specified pool name in QoS conf