Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): refine enhancement & qosLevel updater #403

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Dec 12, 2023

feat(qrm): refine enhancement & qosLevel updater

@csfldf csfldf self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (55d6a6d) 53.79% compared to head (a957d90) 53.78%.
Report is 2 commits behind head on main.

❗ Current head a957d90 differs from pull request most recent head 97476bf. Consider uploading reports for the commit 97476bf to get more accurate results

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 23.07% 8 Missing and 2 partials ⚠️
pkg/util/qos/helper/enhancement_helper.go 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   53.79%   53.78%   -0.02%     
==========================================
  Files         446      446              
  Lines       49385    49413      +28     
==========================================
+ Hits        26569    26579      +10     
- Misses      19806    19815       +9     
- Partials     3010     3019       +9     
Flag Coverage Δ
unittest 53.78% <62.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/refine_enhancement_updater branch from 426c380 to 31aba24 Compare December 12, 2023 13:53
@csfldf csfldf force-pushed the dev/refine_enhancement_updater branch from 31aba24 to a957d90 Compare December 12, 2023 14:01
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Dec 12, 2023
@waynepeking348 waynepeking348 merged commit 799ebad into kubewharf:main Dec 13, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants