Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolation support non-exclusive #405

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

isolation support non-exclusive

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review December 13, 2023 02:43
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch from ff34d7c to d56dd47 Compare December 13, 2023 02:53
@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Dec 13, 2023
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch 4 times, most recently from b4ffcb5 to ed31283 Compare December 13, 2023 10:04
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (705f7fa) 53.57% compared to head (0809ca5) 53.74%.
Report is 6 commits behind head on main.

Files Patch % Lines
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 26.92% 16 Missing and 3 partials ⚠️
...nt/sysadvisor/plugin/qosaware/server/cpu_server.go 34.48% 15 Missing and 4 partials ⚠️
.../sysadvisor/qosaware/resource/cpu/cpu_isolation.go 54.54% 5 Missing ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   53.57%   53.74%   +0.17%     
==========================================
  Files         446      446              
  Lines       49429    49495      +66     
==========================================
+ Hits        26480    26601     +121     
+ Misses      19946    19882      -64     
- Partials     3003     3012       +9     
Flag Coverage Δ
unittest 53.74% <52.17%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Dec 13, 2023
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch 7 times, most recently from b254bbe to 8dcce40 Compare December 14, 2023 06:27
waynepeking348
waynepeking348 previously approved these changes Dec 14, 2023
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Dec 14, 2023
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch from 9129f29 to 49d1ef3 Compare December 14, 2023 08:40
sun-yuliang
sun-yuliang previously approved these changes Dec 14, 2023
waynepeking348
waynepeking348 previously approved these changes Dec 14, 2023
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch 2 times, most recently from ecfdfcc to 7642036 Compare December 14, 2023 10:34
waynepeking348
waynepeking348 previously approved these changes Dec 14, 2023
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch 2 times, most recently from 76a7b4f to 78615cb Compare December 18, 2023 18:54
@luomingmeng luomingmeng force-pushed the dev/isolation_support_non_exclusive branch from 78615cb to 0809ca5 Compare December 19, 2023 02:09
@waynepeking348 waynepeking348 merged commit 9eb636b into kubewharf:main Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants