-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolation support non-exclusive #405
Merged
waynepeking348
merged 1 commit into
kubewharf:main
from
luomingmeng:dev/isolation_support_non_exclusive
Dec 19, 2023
Merged
isolation support non-exclusive #405
waynepeking348
merged 1 commit into
kubewharf:main
from
luomingmeng:dev/isolation_support_non_exclusive
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
from
December 13, 2023 02:53
ff34d7c
to
d56dd47
Compare
waynepeking348
requested review from
waynepeking348,
sun-yuliang,
csfldf and
cheney-lin
and removed request for
waynepeking348
December 13, 2023 03:01
waynepeking348
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Dec 13, 2023
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
4 times, most recently
from
December 13, 2023 10:04
b4ffcb5
to
ed31283
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 53.57% 53.74% +0.17%
==========================================
Files 446 446
Lines 49429 49495 +66
==========================================
+ Hits 26480 26601 +121
+ Misses 19946 19882 -64
- Partials 3003 3012 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waynepeking348
previously approved these changes
Dec 13, 2023
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
7 times, most recently
from
December 14, 2023 06:27
b254bbe
to
8dcce40
Compare
waynepeking348
previously approved these changes
Dec 14, 2023
waynepeking348
added
the
workflow/merge-ready
merge-ready: code is ready and can be merged
label
Dec 14, 2023
sun-yuliang
reviewed
Dec 14, 2023
cmd/katalyst-agent/app/options/sysadvisor/qosaware/resource/cpu/cpu_isolation.go
Outdated
Show resolved
Hide resolved
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
from
December 14, 2023 08:38
8dcce40
to
9129f29
Compare
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
from
December 14, 2023 08:40
9129f29
to
49d1ef3
Compare
sun-yuliang
previously approved these changes
Dec 14, 2023
waynepeking348
previously approved these changes
Dec 14, 2023
luomingmeng
dismissed stale reviews from waynepeking348 and sun-yuliang
via
December 14, 2023 10:26
ecfdfcc
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
2 times, most recently
from
December 14, 2023 10:34
ecfdfcc
to
7642036
Compare
waynepeking348
previously approved these changes
Dec 14, 2023
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
2 times, most recently
from
December 18, 2023 18:54
76a7b4f
to
78615cb
Compare
luomingmeng
force-pushed
the
dev/isolation_support_non_exclusive
branch
from
December 19, 2023 02:09
78615cb
to
0809ca5
Compare
waynepeking348
approved these changes
Dec 19, 2023
sun-yuliang
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
workflow/need-review
review: test succeeded, need to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
isolation support non-exclusive
Which issue(s) this PR fixes:
Special notes for your reviewer: