Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support report numa count to kcnr #410

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

support report numa count to kcnr

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review December 15, 2023 04:40
@luomingmeng luomingmeng force-pushed the dev/add_kcnr_numa_property branch from 4c09564 to 70f0507 Compare December 15, 2023 04:42
@luomingmeng luomingmeng self-assigned this Dec 15, 2023
@luomingmeng luomingmeng added chore workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (705f7fa) 53.57% compared to head (70f0507) 53.55%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   53.57%   53.55%   -0.02%     
==========================================
  Files         446      446              
  Lines       49429    49444      +15     
==========================================
+ Hits        26480    26482       +2     
- Misses      19946    19957      +11     
- Partials     3003     3005       +2     
Flag Coverage Δ
unittest 53.55% <92.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 0c8f537 into kubewharf:main Dec 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants