add timestamp to get feature function #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justadogistaken
added
workflow/merge-hold
waynepeking348
previously approved these changes
Dec 19, 2023
justadogistaken
force-pushed
the
add_timestamp_when_get_feature
branch
from
bf9bfbd to
34cde96
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 53.73% 53.57% -0.16%
==========================================
Files 446 446
Lines 49495 49498 +3
==========================================
- Hits 26596 26520 -76
- Misses 19892 19964 +72
- Partials 3007 3014 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sun-yuliang
approved these changes
Dec 19, 2023
waynepeking348
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding current timestamp_in_second to borwein get feature functions. Which could help feature data provider cache data.