refine cpu provision framework and share region support restrict poli… #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
from
48bfa9d to
0e4bccd
Compare
luomingmeng
added
enhancement
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
from
0e4bccd to
27c569d
Compare
sun-yuliang
reviewed
Dec 22, 2023
| reg.SetEssentials(r.essentials) | ||
| } | ||
|
|
||
| reg.SetLatestCPURequirement(int(knob.Value)) |
There was a problem hiding this comment.
What if control knob's value is meaningless and only action is used? Regulate action doesn't make sense. Regulate ControlKnobNonReclaimedCPUSize only.
| // restrictProvisionControlKnob is to restrict provision control knob by reference policy | ||
| func (r *QoSRegionShare) restrictProvisionControlKnob(originControlKnob map[types.CPUProvisionPolicyName]types.ControlKnob) map[types.CPUProvisionPolicyName]types.ControlKnob { | ||
| restrictedControlKnob := make(map[types.CPUProvisionPolicyName]types.ControlKnob) | ||
| for baseName, controlKnob := range originControlKnob { |
There was a problem hiding this comment.
baseName and refName is confusing since they have similar meaning. baseName -> policyName(or some better name), refName -> refPolicyName might be better.
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
from
27c569d to
5477031
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 53.68% 53.84% +0.15%
==========================================
Files 448 450 +2
Lines 50138 50385 +247
==========================================
+ Hits 26918 27129 +211
- Misses 20149 20187 +38
+ Partials 3071 3069 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
4 times, most recently
from
211aa49 to
6487ed5
Compare
| @@ -158,6 +227,10 @@ func (r *QoSRegionBase) Name() string { | |||
| return r.name | |||
| } | |||
|
|
|||
| func (r *QoSRegionBase) TryUpdateProvision() { | |||
| panic("QoSRegionBase TryUpdateProvision is not implemented") | |||
There was a problem hiding this comment.
don't panic during running states
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
from
3eb6deb to
6cf8c61
Compare
sun-yuliang
previously approved these changes
Dec 25, 2023
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
2 times, most recently
from
4cec379 to
e887eb3
Compare
luomingmeng
force-pushed
the
dev/refractor-sysadvisor-cpu-provision-policy
branch
from
e887eb3 to
cf58cce
Compare
sun-yuliang
approved these changes
Dec 26, 2023
waynepeking348
added
the
workflow/merge-ready
waynepeking348
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cies controlKnob
What type of PR is this?
Enhancements
What this PR does / why we need it:
refine cpu provision framework and share region support restrict controlKnob of policies.
Which issue(s) this PR fixes:
Special notes for your reviewer: