-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model ouput to kcmas #423
add model ouput to kcmas #423
Conversation
85c63fd
to
fb08fbd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 54.35% 54.46% +0.10%
==========================================
Files 472 474 +2
Lines 51936 52084 +148
==========================================
+ Hits 28232 28365 +133
- Misses 20560 20572 +12
- Partials 3144 3147 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fb08fbd
to
5dda432
Compare
@@ -127,3 +163,106 @@ func (infp *InferencePlugin) fetchModelResult(ctx context.Context) { | |||
|
|||
wg.Wait() | |||
} | |||
|
|||
func (infp *InferencePlugin) syncModelResults(ctx context.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not suggest to emit kcmas-related metrics everywhere, maybe it's better to put in metric package instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, but why I emit kcmas-metrics is it's hard to reuse podSyncer under metric package.
So do you accept that is goes as:
Create a new file under metric package. And define an exported function(not belongs to any struct). Then call it under InferencePlugin.Run
?
5dda432
to
bbdf36a
Compare
aafcda3
to
3751ca7
Compare
3751ca7
to
8c6cf06
Compare
8c6cf06
to
9e4a749
Compare
@@ -33,4 +33,37 @@ type BorweinParameter struct { | |||
// the first key is the pod UID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move key description to Results property?
emitter := emitterPool.GetDefaultMetricsEmitter().WithTags("advisor-inference") | ||
metricEmitter := emitterPool.GetDefaultMetricsEmitter().WithTags("advisor-inference") | ||
|
||
dataEmitter, err := emitterPool.GetMetricsEmitter(metricspool.PrometheusMetricOptions{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that dataEmitter isn't used in inferencePlugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to delete that.
removed already.
9e4a749
to
766a246
Compare
766a246
to
f1fe9cf
Compare
Emitting model inference result of pod to kcmas. Which could help centric components leverage the output to work on optimization stuff.