Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(advisor): add indicator offset metric for borwein controller #425

Merged

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Dec 28, 2023

feat(advisor): add indicator offset metric for borwein controller

@csfldf csfldf self-assigned this Dec 28, 2023
@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (3091075) 54.32% compared to head (4f27eba) 54.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
...resource/cpu/region/provisionpolicy/policy_none.go 0.00% 8 Missing ⚠️
.../resource/cpu/region/headroompolicy/policy_none.go 0.00% 7 Missing ⚠️
...plugin/qosaware/resource/cpu/region/region_base.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   54.32%   54.47%   +0.14%     
==========================================
  Files         469      471       +2     
  Lines       51857    51879      +22     
==========================================
+ Hits        28170    28259      +89     
+ Misses      20541    20482      -59     
+ Partials     3146     3138       -8     
Flag Coverage Δ
unittest 54.47% <33.33%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 663aaa5 into kubewharf:main Dec 28, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants