Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locking framework to detect potential deadlocks #427

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

add locking framework to detact potential deadlocks

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Dec 29, 2023
@waynepeking348 waynepeking348 self-assigned this Dec 29, 2023
@waynepeking348 waynepeking348 changed the title add locking framework to detact potential deadlocks add locking framework to detect potential deadlocks Dec 29, 2023
@waynepeking348 waynepeking348 force-pushed the detact-race-condtions-automatically branch 2 times, most recently from 2e5969b to 729b432 Compare December 29, 2023 06:58
@waynepeking348 waynepeking348 force-pushed the detact-race-condtions-automatically branch from 729b432 to 9bb7b4f Compare December 29, 2023 06:59
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (663aaa5) 54.44% compared to head (9bb7b4f) 54.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/util/syntax/lock.go 89.83% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   54.44%   54.50%   +0.05%     
==========================================
  Files         471      472       +1     
  Lines       51879    51936      +57     
==========================================
+ Hits        28247    28306      +59     
+ Misses      20496    20478      -18     
- Partials     3136     3152      +16     
Flag Coverage Δ
unittest 54.50% <90.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit b7a7fa7 into kubewharf:main Dec 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants