-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix container metrics #428
fix container metrics #428
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 54.42% 54.27% -0.15%
==========================================
Files 471 472 +1
Lines 51876 52025 +149
==========================================
+ Hits 28231 28236 +5
- Misses 20488 20649 +161
+ Partials 3157 3140 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/consts/metric.go
Outdated
@@ -125,7 +125,7 @@ const ( | |||
MetricStoreInsContainer = "cpu.store.ins.container" | |||
|
|||
MetricCPUNrThrottledRateContainer = MetricCPUNrThrottledContainer + Rate | |||
MetricCPUNRdPeriodRateContainer = MetricCPUNrPeriodContainer + Rate | |||
MetricCPUNRPeriodRateContainer = MetricCPUNrPeriodContainer + Rate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use same format as above ("Nr") ?
a11656f
to
8d3a664
Compare
8d3a664
to
9ea0225
Compare
There are some metrics have been calculating incorrectly. Try to fix them in the pr.
d
PeriodRateContainer to MetricCPUNRPeriodRateContainer.