Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sysadvisor): consider per numa memory reserved #443

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin requested a review from LuyaoZhong January 11, 2024 12:56
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jan 11, 2024
@LuyaoZhong
Copy link
Contributor

LGTM, please fix CI issue

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a8cb4bd) 54.52% compared to head (78f6428) 54.56%.
Report is 1 commits behind head on main.

Files Patch % Lines
...esource/memory/headroompolicy/policy_numa_aware.go 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   54.52%   54.56%   +0.04%     
==========================================
  Files         493      493              
  Lines       53784    53803      +19     
==========================================
+ Hits        29324    29357      +33     
+ Misses      21245    21223      -22     
- Partials     3215     3223       +8     
Flag Coverage Δ
unittest 54.56% <95.83%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 4da998a into kubewharf:main Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants