refine the implementation for qos configurations #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynepeking348
added
workflow/need-review
waynepeking348
requested review from
caohe,
WangZzzhe,
csfldf,
luomingmeng,
zzzzhhb,
sun-yuliang and
cheney-lin
as code owners
waynepeking348
force-pushed
the
refine-qos-conf
branch
4 times, most recently
from
c4b90a2 to
1b74536
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 54.35% 54.57% +0.21%
==========================================
Files 493 491 -2
Lines 53803 53754 -49
==========================================
+ Hits 29246 29334 +88
+ Misses 21349 21213 -136
+ Partials 3208 3207 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
csfldf
previously approved these changes
Jan 15, 2024
luomingmeng
previously approved these changes
Jan 15, 2024
waynepeking348
dismissed stale reviews from luomingmeng and csfldf
via
774e25b
waynepeking348
force-pushed
the
refine-qos-conf
branch
from
1b74536 to
774e25b
Compare
waynepeking348
force-pushed
the
refine-qos-conf
branch
from
774e25b to
76e89e2
Compare
luomingmeng
approved these changes
Jan 16, 2024
csfldf
approved these changes
Jan 16, 2024
cheney-lin
approved these changes
Jan 16, 2024
caohe
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancements
What this PR does / why we need it:
refine the implementation for qos configurations