Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine(qrm): calculate pool size with much accuracy #445

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Jan 15, 2024

refine(qrm): calculate pool size with much accuracy

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: Patch coverage is 59.57447% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 55.01%. Comparing base (d0d9365) to head (8f597e3).
Report is 1 commits behind head on main.

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 40.47% 25 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/util.go 50.00% 1 Missing and 2 partials ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 40.00% 3 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 77.77% 2 Missing ⚠️
...ins/cpu/nativepolicy/policy_allocation_handlers.go 50.00% 2 Missing ⚠️
pkg/agent/qrm-plugins/util/util.go 71.42% 2 Missing ⚠️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   54.91%   55.01%   +0.10%     
==========================================
  Files         503      503              
  Lines       54842    54878      +36     
==========================================
+ Hits        30116    30192      +76     
+ Misses      21485    21440      -45     
- Partials     3241     3246       +5     
Flag Coverage Δ
unittest 55.01% <59.57%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf self-assigned this Jan 15, 2024
@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jan 15, 2024
@csfldf csfldf removed the enhancement New feature or request label Jan 16, 2024
@csfldf csfldf force-pushed the dev/cpu_req_ceil branch 2 times, most recently from 1013f47 to e72cf5c Compare January 25, 2024 08:35
@csfldf csfldf force-pushed the dev/cpu_req_ceil branch 2 times, most recently from 1037ef3 to 67add45 Compare February 22, 2024 07:28
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Feb 27, 2024
@waynepeking348 waynepeking348 merged commit fa304f9 into kubewharf:main Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants