-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(eviction): support to config eviciton tolerance duration #450
Conversation
e2fddc5
to
040060d
Compare
040060d
to
d2cf236
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 54.38% 54.95% +0.56%
==========================================
Files 491 500 +9
Lines 53754 54540 +786
==========================================
+ Hits 29235 29971 +736
- Misses 21312 21334 +22
- Partials 3207 3235 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6a87e85
to
81daf37
Compare
deletionGracePeriodGetter := func() int64 { | ||
return conf.GetDynamicConfiguration().ReclaimedResourcesEvictionConfiguration.DeletionGracePeriod | ||
} | ||
thresholdMetToleranceDuration := func() int64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to keep this variable's naming style along with others, maybe "thresholdMetToleranceDurationGetter"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified, thanks
81daf37
to
7f49d1e
Compare
7f49d1e
to
5badcaf
Compare
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
5badcaf
to
e208bf8
Compare
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: