Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eviction): support to config eviciton tolerance duration #450

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (e80b616) 54.38% compared to head (e208bf8) 54.95%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/agent/orm/manager.go 52.90% 59 Missing and 14 partials ⚠️
pkg/agent/orm/topology/policy_numeric.go 86.09% 15 Missing and 6 partials ⚠️
pkg/agent/orm/topology/topologyhint.go 21.05% 14 Missing and 1 partial ⚠️
pkg/agent/orm/endpoint/endpoint.go 0.00% 9 Missing ⚠️
pkg/agent/orm/topology/manager.go 91.58% 7 Missing and 2 partials ⚠️
cmd/katalyst-agent/app/options/orm/orm_base.go 63.63% 4 Missing ⚠️
pkg/agent/orm/pod_resource.go 73.33% 3 Missing and 1 partial ⚠️
pkg/util/bitmask/bitmask.go 96.96% 2 Missing and 1 partial ⚠️
.../adminqos/eviction/reclaimed_resources_eviction.go 66.66% 2 Missing ⚠️
pkg/agent/orm/pluginhandler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   54.38%   54.95%   +0.56%     
==========================================
  Files         491      500       +9     
  Lines       53754    54540     +786     
==========================================
+ Hits        29235    29971     +736     
- Misses      21312    21334      +22     
- Partials     3207     3235      +28     
Flag Coverage Δ
unittest 54.95% <82.97%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin force-pushed the dev/eviction branch 2 times, most recently from 6a87e85 to 81daf37 Compare January 19, 2024 02:47
luomingmeng
luomingmeng previously approved these changes Jan 19, 2024
@cheney-lin cheney-lin self-assigned this Jan 19, 2024
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jan 19, 2024
deletionGracePeriodGetter := func() int64 {
return conf.GetDynamicConfiguration().ReclaimedResourcesEvictionConfiguration.DeletionGracePeriod
}
thresholdMetToleranceDuration := func() int64 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to keep this variable's naming style along with others, maybe "thresholdMetToleranceDurationGetter"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified, thanks

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin changed the title refactor(eviction): support config eviciton tolerance duration refactor(eviction): support to config eviciton tolerance duration Jan 19, 2024
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jan 19, 2024
@waynepeking348 waynepeking348 merged commit df34d1e into kubewharf:main Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants