Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eviction): add qos tag #457

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

nightmeng
Copy link
Collaborator

What type of PR is this?

Features

What this PR does / why we need it:

Add Pod QoS into metric tag

Which issue(s) this PR fixes:

Special notes for your reviewer:

@nightmeng nightmeng requested a review from zzzzhhb as a code owner January 23, 2024 07:05
@nightmeng nightmeng force-pushed the dev/add-eviction-qos-tag branch from 6fa9116 to e5fcd62 Compare January 23, 2024 07:06
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (3c06012) 54.80% compared to head (e5fcd62) 55.00%.

Files Patch % Lines
pkg/agent/evictionmanager/manager.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   54.80%   55.00%   +0.20%     
==========================================
  Files         499      499              
  Lines       54534    54540       +6     
==========================================
+ Hits        29888    30002     +114     
+ Misses      21419    21301     -118     
- Partials     3227     3237      +10     
Flag Coverage Δ
unittest 55.00% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 3c99504 into kubewharf:main Jan 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants