feat(async_work): add async work duration and panic metrics #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,6 +116,17 @@ func (aws *AsyncWorkers) handleWork(ctx context.Context, workName string, work * | |||
| defer func() { | |||
| if r := recover(); r != nil { | |||
| handleErr = fmt.Errorf("recover from %v", r) | |||
|
|
|||
| metricErr := EmitCustomizedAsyncedMetrics(ctx, | |||
There was a problem hiding this comment.
will workName always be a valid metric-name? will it contain some non-supported characters?
There was a problem hiding this comment.
In addition to existing EmitAsyncedMetrics, I add another function EmitCustomizedAsyncedMetrics in this pr. And it accepts metric name as parameter. I use specified metric "name async_work_duration_ms" and "async_work_panic" in this pr and they are both valid names.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 54.80% 54.78% -0.02%
==========================================
Files 499 499
Lines 54534 54571 +37
==========================================
+ Hits 29888 29898 +10
- Misses 21419 21441 +22
- Partials 3227 3232 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
csfldf
added
workflow/need-review
waynepeking348
approved these changes
Jan 24, 2024
zzzzhhb
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(async_work): add async work duration and panic metrics