Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sysadvisor): add idle status for region #468

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5e7887c) 54.91% compared to head (5fe1fe3) 54.86%.

Files Patch % Lines
...urce/cpu/region/region_dedicated_numa_exclusive.go 58.33% 10 Missing ⚠️
...plugin/qosaware/resource/cpu/region/region_base.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   54.91%   54.86%   -0.06%     
==========================================
  Files         503      503              
  Lines       54789    54816      +27     
==========================================
- Hits        30088    30074      -14     
- Misses      21455    21502      +47     
+ Partials     3246     3240       -6     
Flag Coverage Δ
unittest 54.86% <55.17%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jan 31, 2024
@cheney-lin cheney-lin self-assigned this Jan 31, 2024
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jan 31, 2024
@waynepeking348 waynepeking348 merged commit fa629f3 into kubewharf:main Feb 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants