-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support node metrics reporter #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ea531b
to
491011a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
+ Coverage 54.91% 55.06% +0.14%
==========================================
Files 503 506 +3
Lines 54842 55246 +404
==========================================
+ Hits 30116 30420 +304
- Misses 21485 21567 +82
- Partials 3241 3259 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8a4ba8f
to
32c0cb1
Compare
aeb5bde
to
18b0000
Compare
luomingmeng
reviewed
Feb 21, 2024
pkg/agent/sysadvisor/plugin/qosaware/reporter/headroom_reporter.go
Outdated
Show resolved
Hide resolved
sun-yuliang
reviewed
Feb 22, 2024
18b0000
to
4155c4c
Compare
7a3e370
to
01ee60e
Compare
luomingmeng
previously approved these changes
Feb 26, 2024
01ee60e
to
64f965b
Compare
4eb2b6e
to
7c7f3ac
Compare
luomingmeng
previously approved these changes
Feb 26, 2024
csfldf
previously approved these changes
Feb 26, 2024
sun-yuliang
previously approved these changes
Feb 26, 2024
aee146e
7c7f3ac
to
aee146e
Compare
csfldf
previously approved these changes
Feb 26, 2024
luomingmeng
previously approved these changes
Feb 26, 2024
sun-yuliang
previously approved these changes
Feb 26, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
36c15c6
aee146e
to
36c15c6
Compare
waynepeking348
approved these changes
Feb 27, 2024
csfldf
approved these changes
Feb 27, 2024
sun-yuliang
approved these changes
Feb 27, 2024
luomingmeng
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: