Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node metrics reporter #474

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 78.06604% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 55.06%. Comparing base (d0d9365) to head (36c15c6).
Report is 1 commits behind head on main.

Files Patch % Lines
...or/plugin/qosaware/reporter/nodemetric_reporter.go 79.21% 52 Missing and 17 partials ⚠️
...sadvisor/qosaware/reporter/node_metric_reporter.go 70.96% 9 Missing ⚠️
pkg/agent/sysadvisor/plugin/qosaware/qos_aware.go 67.85% 8 Missing and 1 partial ⚠️
...p/options/sysadvisor/qosaware/reporter/reporter.go 75.00% 4 Missing ⚠️
...pp/options/sysadvisor/qosaware/qos_aware_plugin.go 85.71% 1 Missing ⚠️
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   54.91%   55.06%   +0.14%     
==========================================
  Files         503      506       +3     
  Lines       54842    55246     +404     
==========================================
+ Hits        30116    30420     +304     
- Misses      21485    21567      +82     
- Partials     3241     3259      +18     
Flag Coverage Δ
unittest 55.06% <78.06%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin force-pushed the dev/node_metric branch 3 times, most recently from 8a4ba8f to 32c0cb1 Compare February 18, 2024 15:29
@cheney-lin cheney-lin self-assigned this Feb 18, 2024
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Feb 18, 2024
@cheney-lin cheney-lin force-pushed the dev/node_metric branch 9 times, most recently from aeb5bde to 18b0000 Compare February 21, 2024 03:49
@cheney-lin cheney-lin force-pushed the dev/node_metric branch 3 times, most recently from 7a3e370 to 01ee60e Compare February 23, 2024 02:34
luomingmeng
luomingmeng previously approved these changes Feb 26, 2024
@cheney-lin cheney-lin force-pushed the dev/node_metric branch 2 times, most recently from 4eb2b6e to 7c7f3ac Compare February 26, 2024 05:42
luomingmeng
luomingmeng previously approved these changes Feb 26, 2024
csfldf
csfldf previously approved these changes Feb 26, 2024
sun-yuliang
sun-yuliang previously approved these changes Feb 26, 2024
csfldf
csfldf previously approved these changes Feb 26, 2024
luomingmeng
luomingmeng previously approved these changes Feb 26, 2024
sun-yuliang
sun-yuliang previously approved these changes Feb 26, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Feb 27, 2024
@waynepeking348 waynepeking348 merged commit 129d32b into kubewharf:main Feb 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants