feat(cgroup): setting memory.low/min in ApplyMemory() #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 54.93% 54.85% -0.08%
==========================================
Files 503 503
Lines 54822 54840 +18
==========================================
- Hits 30114 30084 -30
- Misses 21471 21508 +37
- Partials 3237 3248 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lubinszARM
force-pushed
the
pr_mem_min
branch
3 times, most recently
from
245c0b6 to
012740e
Compare
memory.low: cgroup memory that will not be reclaimed in soft_limit_reclaim phase of kswapd memory.min: cgroup memory that can never be reclaimed by kswapd Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_mem_min
branch
from
012740e to
0056135
Compare
csfldf
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting memory.low/min in ApplyMemory()
descriptions for memory.low & memory.min:
memory.low: cgroup memory that will not be reclaimed in soft_limit_reclaim phase of kswapd
memory.min: cgroup memory that can never be reclaimed by kswapd
What type of PR is this?
Enhancements
What this PR does / why we need it:
Provide the interfaces of memory.low/min to help users to set.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Through these new interfaces, we can set a series of special settings for the critical services, such as katalyst, malachite.