-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qrm): refine healthz #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzzhhb
requested review from
csfldf,
luomingmeng and
waynepeking348
as code owners
February 21, 2024 12:20
zzzzhhb
force-pushed
the
refine_healthz
branch
from
February 23, 2024 06:54
1d11a30
to
edf17a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 54.91% 55.13% +0.21%
==========================================
Files 513 513
Lines 56747 56953 +206
==========================================
+ Hits 31163 31401 +238
+ Misses 22255 22199 -56
- Partials 3329 3353 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zzzzhhb
force-pushed
the
refine_healthz
branch
4 times, most recently
from
February 26, 2024 12:46
831c9dc
to
e9763ce
Compare
waynepeking348
previously approved these changes
Feb 26, 2024
csfldf
reviewed
Feb 27, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_async_handler.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Feb 27, 2024
zzzzhhb
force-pushed
the
refine_healthz
branch
4 times, most recently
from
February 29, 2024 08:11
6219b51
to
d6b6a97
Compare
zzzzhhb
force-pushed
the
refine_healthz
branch
2 times, most recently
from
March 11, 2024 03:29
f9ab27a
to
fbf1b9b
Compare
csfldf
approved these changes
Mar 12, 2024
waynepeking348
approved these changes
Mar 12, 2024
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* feat(qrm): refine healthz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
refine healthz interface, aggregate all exception info to healthz api.
Which issue(s) this PR fixes:
Special notes for your reviewer: