Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): refine healthz #482

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat(qrm): refine healthz #482

merged 2 commits into from
Mar 13, 2024

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Feb 21, 2024

What type of PR is this?

Features

What this PR does / why we need it:

refine healthz interface, aggregate all exception info to healthz api.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 61.87291% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 55.13%. Comparing base (751d44b) to head (1240043).
Report is 1 commits behind head on main.

Files Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_async_handler.go 45.23% 19 Missing and 4 partials ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 44.11% 15 Missing and 4 partials ⚠️
...ugins/memory/dynamicpolicy/policy_async_handler.go 72.72% 17 Missing and 1 partial ⚠️
pkg/util/general/healthz.go 83.52% 11 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 25.00% 10 Missing and 2 partials ⚠️
cmd/base/healthz.go 0.00% 10 Missing ⚠️
cmd/base/context.go 20.00% 8 Missing ⚠️
...m-plugins/memory/handlers/sockmem/sockmem_linux.go 46.15% 7 Missing ⚠️
cmd/base/options/generic.go 66.66% 1 Missing ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   54.91%   55.13%   +0.21%     
==========================================
  Files         513      513              
  Lines       56747    56953     +206     
==========================================
+ Hits        31163    31401     +238     
+ Misses      22255    22199      -56     
- Partials     3329     3353      +24     
Flag Coverage Δ
unittest 55.13% <61.87%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb force-pushed the refine_healthz branch 4 times, most recently from 831c9dc to e9763ce Compare February 26, 2024 12:46
@zzzzhhb zzzzhhb changed the title [WIP]feat(qrm): refine healthz feat(qrm): refine healthz Feb 26, 2024
waynepeking348
waynepeking348 previously approved these changes Feb 26, 2024
@zzzzhhb zzzzhhb force-pushed the refine_healthz branch 4 times, most recently from 6219b51 to d6b6a97 Compare February 29, 2024 08:11
@zzzzhhb zzzzhhb force-pushed the refine_healthz branch 2 times, most recently from f9ab27a to fbf1b9b Compare March 11, 2024 03:29
@zzzzhhb zzzzhhb merged commit 65db018 into kubewharf:main Mar 13, 2024
10 checks passed
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants