Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spd support extended indicator sdk and extended baseline #495

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng self-assigned this Mar 4, 2024
@luomingmeng luomingmeng force-pushed the dev/spd-support-extended-indicator branch 3 times, most recently from a2e45e8 to c21702f Compare March 4, 2024 07:14
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 65.61086% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 55.16%. Comparing base (81e99e9) to head (da42b65).

Files Patch % Lines
pkg/metaserver/spd/manager.go 35.00% 18 Missing and 8 partials ⚠️
pkg/util/spd_baseline.go 58.06% 16 Missing and 10 partials ⚠️
pkg/util/spd.go 69.38% 11 Missing and 4 partials ⚠️
pkg/controller/spd/spd_indicator.go 50.00% 3 Missing and 1 partial ⚠️
pkg/controller/spd/spd.go 66.66% 2 Missing and 1 partial ⚠️
pkg/controller/spd/spd_baseline.go 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   55.02%   55.16%   +0.14%     
==========================================
  Files         513      513              
  Lines       56993    57168     +175     
==========================================
+ Hits        31358    31539     +181     
+ Misses      22289    22245      -44     
- Partials     3346     3384      +38     
Flag Coverage Δ
unittest 55.16% <65.61%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/spd-support-extended-indicator branch 11 times, most recently from 21c7fc9 to fccd656 Compare March 8, 2024 02:31
@luomingmeng luomingmeng marked this pull request as ready for review March 8, 2024 06:15
@luomingmeng luomingmeng force-pushed the dev/spd-support-extended-indicator branch from fccd656 to 4673885 Compare March 8, 2024 06:53
@luomingmeng luomingmeng force-pushed the dev/spd-support-extended-indicator branch from 4673885 to 5d62ca7 Compare March 15, 2024 05:01
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Mar 15, 2024
@luomingmeng luomingmeng force-pushed the dev/spd-support-extended-indicator branch from 5d62ca7 to da42b65 Compare March 15, 2024 05:04
@luomingmeng luomingmeng merged commit 2d6e0a3 into kubewharf:main Mar 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants